Renaming file in bash script breaks the script

Question

Good day! I have the following script which is supposed to rename and then send files in a folder on my Mac to an FTP server.

for f in "$@"
    do
        mv "$f" "${f%.mpeg}.mpg"
        curl -T "$f" ftp://1.2.3.4/Vol123456-01/MPEG/ --user me:secret
        mv "$f" "/Users/me/Sent Stuff"
    done

That works fine except for that first mv line. The script successfully renames the file, but then the following commands seem to no longer be able to find "$f". I am pretty new to bash scripting. Is there a way to refresh perhaps what "$f" means so that the curl and mv lines know what it is? Thanks in advance!

Mad Physicist · Accepted Answer · 2014-01-28 20:29:08Z

5

You have nailed the problem exactly. The first mv renames the file. The original name "$f" no longer exists. Try this:

for f in "$@"
do
    g="${f%.mpeg}.mpg"
    mv "$f" "$g"
    curl -T "$g" ftp://1.2.3.4/Vol123456-01/MPEG/ --user me:secret
    mv "$g" "/Users/me/Sent Stuff"
done

answered Jan 28, 2014 at 20:29

Mad Physicist

116k29 gold badges202 silver badges292 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

mrcoulson Over a year ago

That does it! Thanks!

Jonathan Leffler · Accepted Answer · 2014-01-28 20:32:23Z

3

You could store the new name in another variable and then use that when you want to reach the file.

newname="${f%.mpeg}.mpg"

and then use the "$newname" for getting the variable.

edited Jan 28, 2014 at 20:32

Jonathan Leffler

760k145 gold badges961 silver badges1.3k bronze badges

answered Jan 28, 2014 at 20:29

claj

5,4322 gold badges29 silver badges31 bronze badges

Collectives™ on Stack Overflow

Renaming file in bash script breaks the script

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related