rename file names work in command prompt but not in bash script

Question

I'm trying to rename commands in a bash script. If I run for example:

echo /home/scientist/mySalesData/campaignData_1482386214.24417.csv  | sed 's/\(.*\)\(_.*\)/mv \"&" \"\1.csv\"/' | bash

It works fine and gives me campaignData.csv in the directory /home/scientist/mySalesData/ .

However, if I put this in a bash script as follows:

for f in /home/scientist/SalesData/*; do
if [ -f "$f" ]; 
  cp "$f" /home/scientist/SalesForce/SalesData/Backups/                                                                
  echo $f$ | sed 's/\(.*\)\(_.*\)/mv \"&" \"\1.csv\"/' | bash |        
fi 
done

I get:

mv: cannot stat '/home/scientist/SalesData/campaignData_1482386214.24417.csv$': No such file or directory

Any help would be much appreciated!

You have a simple typo. Change $f$ to "$f" and add the missing then. — Roland Illig
– Roland Illig, Commented Dec 22, 2016 at 6:42

Roland Illig · Accepted Answer · 2016-12-22 06:56:57Z

2

cd "$srcdir"
for f in *; do
  if [ -f "$f" ]; then
    cp "./$f" "$dstdir/${f%_*}.csv"
  fi
done

The % is the strip shortest suffix pattern operator.

edited Dec 22, 2016 at 6:56

answered Dec 22, 2016 at 6:50

Roland Illig

41.9k12 gold badges92 silver badges127 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

user1357015 Over a year ago

oh that's neat. Learned something new with that operator.

heemayl · Accepted Answer · 2016-12-22 06:41:33Z

2

You have a trailing $ here:

echo $f$

remove that (and quote the expansion):

echo "$f"

You could use here string too:

sed ... <<<"$f"

answered Dec 22, 2016 at 6:41

heemayl

42.5k10 gold badges86 silver badges87 bronze badges

Collectives™ on Stack Overflow

rename file names work in command prompt but not in bash script

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related