python TypeError not all arguments converted during string formatting [duplicate]

Question

The program is meant to find the odd number in the string by checking if the number can be divided by 2 without a remainder, here is the code:

def iq_test(numbers): 
    for x in numbers.split():
       if x % 2 != 0:
          return x 

iq_test("1 2 3 4 5")

Here is the error i get when i run the code:

Traceback (most recent call last):
File "python", line 6, in <module>
File "python", line 3, in iq_test
TypeError: not all arguments converted during string formatting

Any help would be appreciated

if x % 2 != 0: --> if int(x) % 2 != 0: (python thinks you're doing string formatting using the percent sign). Btw. you might want to do something else than return since it'll return after a single true if and, thus, only process the number 1. — jDo
– jDo, Commented Jun 19, 2016 at 22:44

Moses Koledoye · Accepted Answer · 2016-06-19 22:55:13Z

1

When you use % (or more verbose operator.mod) on string literals, you're attempting to format:

>>> a = 'name'
>>> ('%s' % a) == 'name'
True

But you intend to use this on int, so you need to cast your string literals to integer:

if int(x) % 2 != 0

Then mod will attempt to find the modulus instead of attempting to format.

However, your function will return as soon as it finds the first odd number. If you intend to find all the odd numbers and not just the first, you can accumulate the odd numbers in a list and return the joined list:

def iq_test(numbers): 
    lst = []
    for x in numbers.split():
       if int(x) % 2 != 0:
           lst.append(x) 

    return ' '.join(lst)

iq_test("1 2 3 4 5")
# "1 3 5"

Another sleek alternative will be to try out generator functions/expressions and yield

edited Jun 19, 2016 at 22:55

answered Jun 19, 2016 at 22:42

Moses Koledoye

78.8k8 gold badges139 silver badges141 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

code_onkel · Accepted Answer · 2016-06-19 22:48:10Z

0

x is a string, therefore the % resolves to string interpolation instead of modulo. Use int(x) % 2 == 0.

The error is raised, because 2 is the string formatting argument, but the string does not contain a matching amount of format specifiers.

edited Jun 19, 2016 at 22:48

answered Jun 19, 2016 at 22:42

code_onkel

2,9822 gold badges18 silver badges33 bronze badges

Collectives™ on Stack Overflow

python TypeError not all arguments converted during string formatting [duplicate]

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related