Lazy Property Initialization in static class C#

Question

I have been given this code

public static class Logger
{
    public static Func<ILogger> LoggerFactory;
    private static readonly Lazy<ILogger> _log = new Lazy<ILogger>(LoggerFactory);

    public static ILogger Instance
    {
        get
        {
            return _log.Value;
        }
        public static ILogger ConfigureLogging(string AppName, Version AppVersion)
        {
             // stuff
        }
    }
}

This static class is used in the application:

Logger.LoggerFactory = () => Logger.ConfigureLogging(AppName, AppVersion);
Logger.Instance.Information("Starting application");

I would expect the first row to set the LoggerFactory; however on the first attempt of writing to the log, an exception has thrown because the static Func LoggerFactory hasn't been set yet.

What's wrong with this code?

Thanks

Because when you create _log, LoggerFactory is null. By the time you do Logger.LoggerFactory = ... you've already initialized _log — Matt Burland
– Matt Burland, Commented Jul 27, 2016 at 14:41
You could try: private static readonly Lazy<ILogger> _log = new Lazy<ILogger>(() => LoggerFactory()); — Matt Burland
– Matt Burland, Commented Jul 27, 2016 at 14:42

Community · Accepted Answer · 2017-05-23 12:08:06Z

9

The quick and dirty fix for this would be to do this:

private static readonly Lazy<ILogger> _log = new Lazy<ILogger>(() => LoggerFactory());

Lazy takes a function that will be executed when you first try to access the Value, but in your code you are passing it null because you haven't yet initialized LoggerFactory. The static initializer in your class will run before the first time any of the static fields are accessed, so your attempt to access LoggerFactory will trigger your _log field to initialize (if it hasn't already) at which point LoggerFactory is null. See, for example, here for some discussion on static initialization.

You can defer accessing LoggerFactory but wrapping it in a function.

edited May 23, 2017 at 12:08

CommunityBot

11 silver badge

answered Jul 27, 2016 at 14:47

Matt Burland

45.3k18 gold badges110 silver badges182 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Steve · Accepted Answer · 2016-07-27 14:44:05Z

3

Here is the execution order:

private static readonly Lazy<ILogger> _log = new Lazy<ILogger>(null);
//LoggerFactory is null at this point

Logger.LoggerFactory = () => Logger.ConfigureLogging(AppName, AppVersion);
Logger.Instance.Information("Starting application");

and thus _log will stay as null

answered Jul 27, 2016 at 14:44

Steve

12k7 gold badges48 silver badges85 bronze badges

1 Comment

ab_732 Over a year ago

Thanks for the explanation, now I understand the exec order.

Collectives™ on Stack Overflow

Lazy Property Initialization in static class C#

2 Answers 2

Comments

1 Comment

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Linked

Related