using ifstream to read in number from a text file into a std::vector<int>

Question

I have a read function which takes numbers from a text file and stored them into a data structure. I have made this function.

void VectorIntStorage::read(ifstream &in)
{
    if(in.is_open())
    {
        for (int i = 0; in && i < n; ++ i) 
        {
            in >> vectorStorage<i>;
        }
    }
}

I am trying to add them into a vector structure, is this code correct??

user2100815 · Accepted Answer · 2011-04-25 16:09:38Z

2

No, it isn't. The canonical way would be:

vector <int> v;
int n;

while( f >> n ) {
    v.push_back( n );
}

where f is an ifstream.

answered Apr 25, 2011 at 16:09

user2100815

Sign up to request clarification or add additional context in comments.

Comments

qwerty · Accepted Answer · 2011-04-25 16:23:55Z

0

No, if you write you code this way the compilation will fail. Maybe you can allocate enough space for the vector and then store the date the ifstream read.

vector<int> v(MAX_SIZE);
int iIndex = 0;

while((iIndex < v.size()) && (in >> v[iIndex]))
{
    ++iIndex;
}

answered Apr 25, 2011 at 16:23

qwerty

1602 silver badges8 bronze badges

1 Comment

набиячлэвэли Over a year ago

This is so bad... Looks like C, that has been hit by a truck. Seriously. What was happening in the person's head while they were writing this?

Collectives™ on Stack Overflow

using ifstream to read in number from a text file into a std::vector<int>

2 Answers 2

Comments

1 Comment

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Your Answer

Sign up or log in

Post as a guest

Related