C# Trying to output a Char array but in reverse order

Question

I have made the code so that it takes in an input, a string, and then;

Outputs the string, no changes made
Shows the string but from the array, so that it would be listed
It would then output the list after it has been reversed.

So far with my code i have done this:

        string input;
        int arLENGTH;
        Console.WriteLine("Enter the string you want to be reversed.");
        input = Console.ReadLine(); 
        
        char[] chars = input.ToCharArray();
        Console.WriteLine("Original string: " + input);
        Console.WriteLine("Character array(Not Reversed):");
        for (int a = 0; a < chars.Length; a++)
        {
            Console.WriteLine(chars[a]);
        }
        arLENGTH = chars.Length;
        Console.WriteLine("Reversed String: ");
        while (arLENGTH > chars.Length)
        {
            Console.WriteLine(chars[arLENGTH]);
            arLENGTH--;
        }
        Console.ReadLine();

When i run it, it outputs Reversed String, and then just leaves it blank.

take a look at this post: stackoverflow.com/questions/20771798/… — Nolan Bradshaw
– Nolan Bradshaw, Commented Oct 1, 2020 at 19:22
@NolanBradshaw Ty dude, i was looking for something like this but i couldn't find it. I usually use W3Schools, and im pretty sure it wasn't there. — user13229542
– user13229542, Commented Oct 1, 2020 at 19:27
@NolanBradshaw The real answer is not the accepted one for that SO question. And it's a little dated. — MikeJ
– MikeJ, Commented Oct 1, 2020 at 19:36

MikeJ · Accepted Answer · 2020-10-01 19:40:45Z

1

This become pretty trivial with C# index operators:

    static void Main(string[] _)
    {
        string input = "my input string";

        Console.WriteLine(input);

        for (int i = 1; i <= input.Length; ++i)
            Console.Write(input[^i]);

        Console.WriteLine();
    }

edited Oct 1, 2020 at 19:40

answered Oct 1, 2020 at 19:33

MikeJ

1,3878 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Idle_Mind Over a year ago

I like it...but the syntax still looks weird to my brain! =)

MikeJ Over a year ago

@Idle_Mind it is different. I think your answer, which is also the one linked to by Nolan Bradshaw in the comment above, is clearer. Having the "a--" makes it obvious you're going in reverse. But the new stuff is always fun to play around with.

Idle_Mind Over a year ago

@OrkhanAlikhanov, from Building C# 8.0: "We’re adding a type Index, which can be used for indexing. You can create one from an int that counts from the beginning, or with a prefix ^ operator that counts from the end". Or see the System.Index section.

Orkhan Alikhanov Over a year ago

@Idle_Mind Thank you for a detailed explanation! I've used C#6 long ago, it seems cool updates has happened since then

AbbathCL · Accepted Answer · 2020-10-01 19:25:34Z

0

if you put arLENGTH > chars.Length

that's mean you put Length > Length if Length is 5 then you said 5 > 5 you should put while arLENGTH > 0

hope you understand.

--- EDITED

I just notice something else you should put [length -1]

            string input;
            int arLENGTH;
            Console.WriteLine("Enter the string you want to be reversed.");
            input = Console.ReadLine();

            char[] chars = input.ToCharArray();
            Console.WriteLine("Original string: " + input);
            Console.WriteLine("Character array(Not Reversed):");
            for (int a = 0; a < chars.Length; a++)
            {
                Console.WriteLine(chars[a]);
            }
            arLENGTH = chars.Length;
            Console.WriteLine("Reversed String: ");
            while (arLENGTH > 0)
            {
                Console.WriteLine(chars[arLENGTH - 1]);
                arLENGTH--;
            }
            Console.ReadLine();

answered Oct 1, 2020 at 19:25

AbbathCL

997 bronze badges

2 Comments

MikeJ Over a year ago

I know you're mirroring his original, but you don't need the char arrays at all.

AbbathCL Over a year ago

I'm Just correcting him, that's the process of learning, if he wants indexes or something that's another question and learning. he asked what is wrong and I point what's wrong after a couple minutes I edited just by looking. just I repeat different is another question and not please solve my homework. (sorry my english)

Jasmeet · Accepted Answer · 2020-10-01 19:30:45Z

0

The issue is with your while loop. You are assigning arLENGTH = chars.Length; and then checking in while arLENGTH > chars.Length, which will never be true, because both contain the same value.

Update your while loop so that

while (arLENGTH > 0)
{
   Console.WriteLine(chars[arLENGTH-1]);
   arLENGTH--;
}

answered Oct 1, 2020 at 19:30

Jasmeet

1,49515 silver badges32 bronze badges

Comments

Idle_Mind · Accepted Answer · 2020-10-01 19:35:57Z

0

Why not use a for loop to print the reverse, just like you did for forwards?

You just need start at Length - 1, continue as long as you are greater than or equal to zero, and decrement the value.

Looks like this:

Console.WriteLine("Reversed String:");
for (int a = (chars.Length - 1); a >= 0; a--)
{
    Console.WriteLine(chars[a]);
}

answered Oct 1, 2020 at 19:35

Idle_Mind

39.3k3 gold badges31 silver badges40 bronze badges

2 Comments

user13229542 Over a year ago

I tried this but i did it a different way so it didnt work. Good to know that i was on the right track though.

MikeJ Over a year ago

@ExiusCain or using the index operators.

Collectives™ on Stack Overflow

C# Trying to output a Char array but in reverse order

4 Answers 4

4 Comments

2 Comments

Comments

2 Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

4 Comments

2 Comments

Comments

2 Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related