Creating a reverse ordered array

Question

I am currently trying to create an array and display it reverse or descending order. It currently displays a list of numbers but sometimes it does not follow the correct descending order. I believe the issues is in the if statement in between the two for loops, each time I am comparing a random number between 1-101 with the first number in your array. Instead of doing it that way, How can I compare the numbers in the array with each other? Or any suggestion in proving my reverse order array generator?

CODE

namespace reverseArray
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }
        long operations = 0;
        int size;
        int max;
        int[] createArray;
        int[] sortArray;
        int[] copyArray;

public void ReverseOrder()
        {
            size = Convert.ToInt32(textBoxSize.Text);
            max = Convert.ToInt32(textBoxMax.Text);
            createArray = new int[size];
            copyArray = new int[size];
            sortArray = new int[size];

            createArray[size - 1] = 1;

            for (int i = size - 1; i > 0; i--)
            {
                createArray[i - 1] = createArray[i] + r.Next(1, max);
            }

            for (int i = size - 1; i > 0; i--)
            {
                if (r.Next(1, 101) < createArray[0])
                {
                    for (int x = size - 1; x > 0; x--)
                    {
                        createArray[x] = r.Next(1, createArray[0]);
                    }
                }
            }

        }


private void buttonCreateArray_Click(object sender, EventArgs e)
        {

ReverseOrder();

}

}

}

Why aren't you using the LINQ Reverse, OrderBy, or OrderByDescending functions? Your question is really confusing. r.Next looks like a Random instance. What on earth are you doing in the loops? — Roland Mai
– Roland Mai, Commented Nov 24, 2012 at 5:20
Of the three arrays you have defined (createArray, copyArray and sortArray), which is supposed to be the array of ints in descending order? — Edmund Schweppe
– Edmund Schweppe, Commented Nov 24, 2012 at 5:32
@charliecodex23 If createArray is the array of ints in descending order, what is the original array that you created initially? — Edmund Schweppe
– Edmund Schweppe, Commented Nov 24, 2012 at 5:44
@EdmundSchweppe. Clarification: the createArray is the original array created initially. Then the for loops arranges(or tries to) the array in descending order. — user1434156
– user1434156, Commented Nov 24, 2012 at 17:13

Max · Accepted Answer · 2012-11-24 05:26:37Z

1

No need to implement your own algorithm to sort or reverse an array.

Use Array.Sort and/or Array.Reverse.

To sort in descending order, first sort then reverse the array.

answered Nov 24, 2012 at 5:26

Max

10k11 gold badges61 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Dmytro · Accepted Answer · 2012-11-24 18:11:36Z

0

Use LINQ

using System.Linq;

namespace reverseArray
{
        public partial class Form1 : Form
        {
            public Form1()
            {
                InitializeComponent();
            }
            long operations = 0;
            int size;
            int max;
            int[] createArray;
            int[] orderedArray;
            int[] orderedByDescendingArray;    

            public int[] CreateArray(int size, int max)
            {
                var result = new int[size];
                Random r = new Random();
                for(int i; i<size; i++)
                {
                   result[i] = r.Next(max);
                }
                return result;
            }


            private void buttonCreateArray_Click(object sender, EventArgs e)
            {
                size = Convert.ToInt32(textBoxSize.Text);
                max = Convert.ToInt32(textBoxMax.Text);

                createArray = CreateArray(size, max);
                orderedArray = array.OrderBy(a => a);
                orderedByDescendingArray = array.OrderByDescending(a => a);        
           }
      }
}

//P.S. Code may contain errors coz I typed it directly here.

edited Nov 24, 2012 at 18:11

answered Nov 24, 2012 at 5:31

Dmytro

17.3k28 gold badges88 silver badges133 bronze badges

2 Comments

user1434156 Over a year ago

i try this but i am getting a red line under array.OrderBy and array.OrderByDescending(). The error: does not exist in current context

Dmytro Over a year ago

@charliecodex23, add using System.Linq; directive to the top of your document.

Alexei Levenkov · Accepted Answer · 2012-11-24 05:28:06Z

0

Consder using built methods for sorting like Array.Sort and Enumerable.OrderBy. They have variants that take comaprer to customize sorting.

answered Nov 24, 2012 at 5:28

Alexei Levenkov

101k15 gold badges138 silver badges189 bronze badges

Comments

Himesh · Accepted Answer · 2012-11-24 05:49:17Z

0

no need to use logic to create reverse order array. In C# has default method to reverse it. so used that and you can get output ..

        string fullOrder= Console.ReadLine();
        char[] charArray= fullOrder.ToCharArray();
        Array.Reverse(charArray);
        Console.WriteLine(charArray);
        Console.ReadLine();

answered Nov 24, 2012 at 5:49

Himesh

4581 gold badge3 silver badges15 bronze badges

Collectives™ on Stack Overflow

Creating a reverse ordered array

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

2 Comments

Comments

Comments

Your Answer

Sign up or log in

Post as a guest

Related