Problem when parsing xml string in java

Question

I'm writing an android application, and I would like to get an xml string from web and get all info it contains. First of all, i get the string (this code works):


URL url = new URL("here my adrress");
BufferedReader reader = new BufferedReader(new InputStreamReader(url.openStream()));
String myData = reader.readLine();
reader.close();

Then, I use DOM:


DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
DocumentBuilder db = dbf.newDocumentBuilder();
InputSource is = new InputSource();
is.setCharacterStream(new StringReader(myData));

Still no problem. When I write


Document doc = db.parse(is);

the application doesn't do anything more. It stops, without errors. Can someone please tell me what's going on?

Friedrik · Accepted Answer · 2011-06-30 10:59:21Z

4

I wouldn't know why your code doesn't work since there is no error but I can offer alternatives.

First, I am pretty sure your new InputStream "is" is unnecessary. "parse()" can take "url.openStream()" or "myData" directly as an argument.

Another cause of error could be that your xml data has more than one line(I know you said that the first part of your code worked but I'd rather mention it, just to be sure). If so, "reader.readLine()" will only get you a part of your xml data.

I hope this will help.

answered Jun 30, 2011 at 10:59

Friedrik

3991 gold badge2 silver badges12 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

b3by Over a year ago

That was actually the problem. I changed my code in "Document doc = db.parse(url.openStream()); reader.close();" and it worked like a charm. Very helpful, thank you!

Walid Hossain · Accepted Answer · 2011-06-30 10:44:47Z

1

Use SAXParser instead of DOM parser. SAXParser is more efficient than DOM parser. Here is two good tutorials on SAXParser 1. http://www.androidpeople.com/android-xml-parsing-tutorial-using-saxparser 2. http://www.anddev.org/parsing_xml_from_the_net_-_using_the_saxparser-t353.html

answered Jun 30, 2011 at 10:44

Walid Hossain

2,7142 gold badges29 silver badges39 bronze badges

1 Comment

b3by Over a year ago

It can be quite time-expensive to change all my application parsing from dom to sax T_T

nickfox · Accepted Answer · 2011-06-30 10:58:47Z

Use XmlPullParser, it's very fast. Pass in the string from the web and get a hashtable with all the values.

public Hashtable<String, String> parse(String myData) { 
    XmlPullParser parser = Xml.newPullParser();
    Hashtable<String, String> responseFromServer = new Hashtable<String, String>();

    try {
         parser.setInput(new StringReader (responseString));
         int eventType = parser.getEventType();
         while (eventType != XmlPullParser.END_DOCUMENT) {
             if(eventType == XmlPullParser.START_TAG) {
                 String currentName = parser.getName();
                 String currentText = parser.nextText();

                 if (currentText.trim().length() > 0) {
                     responseFromServer.put(currentName, currentText);
                 } 
             }               
             eventType = parser.next();
         }         
    } catch (Exception e) {
        e.printStackTrace();
    }
    return responseFromServer;
}

Collectives™ on Stack Overflow

Problem when parsing xml string in java

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Linked

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Linked

Related