Forcing JavaScript return false to persist through functions

Question

Thanks for taking time to review this question. I've been trying to fix a problem for one or two hours with no success...

I have a web page that sets a JavaScript variable based on the response from a function:

grade = getScore(questionAnswer, userAnswer, questionType);

(userAnswer is the user's answer to a question and is retrieved from a textarea)

Here is getScore:

function getScore(questionAnswer, userAnswer, questionType) {

    switch(questionType) {
        case 'multiplechoice':
            return scoreMC(questionAnswer, userAnswer);
        break;

        case 'usertypesanswer':
            return scoreTA(questionAnswer, userAnswer);         
        break;

        default:
            return 0
    }   

}

The functions for scoreMC and scoreTA have been tested thoroughly and work great. The issue is that if a user's answer is not formatted correctly, scoreMC or scoreTA will return false. Otherwise it returns the values score and msg. However, instead of getting a "false" value for "grade" when I set the value of the grade variable based on the getScore function, I get "undefined". (We have no problems when the user response validates properly.)

After setting "grade", I have tried to check if any part of it is undefined:

if(typeof(grade.score) !== undefined)

I do not understand why, but even when I see "undefined" in my Firebug console, grade.score passes this check...

Does anyone see what I am doing wrong? Thank you very much for your assistance. I have a lot to learn about JavaScript.

have you tried without the typeof

David Laberge
– David Laberge

2011-09-24 00:20:34 +00:00
Commented Sep 24, 2011 at 0:20 — David Laberge
– David Laberge, Commented Sep 24, 2011 at 0:20

Joe · Accepted Answer · 2011-09-24 00:19:10Z

3

if(typeof(grade.score) !== undefined)

can be

if(grade.score && grade.score !== false) // if I understand your question

or

if(typeof(grade.score) !== "undefined")

typeof returns a string

answered Sep 24, 2011 at 0:19

Joe

82.9k18 gold badges130 silver badges147 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Alex Watt Over a year ago

+1 Thanks so much! I knew it had to be simple. :) I used "if(grade.score && grade.score !== false)" as you suggested and it worked.

Charles Goodwin · Accepted Answer · 2011-09-24 00:26:49Z

0

If no return statement is used (or an empty return with no value), JavaScript returns undefined.

It is almost certain that one of your score functions (scoreMC, scoreTA, whose code you should have included in the question) does not return a value i.e.

return;

Or just reaches the end of the function code block without encountering a return.

edited Sep 24, 2011 at 0:26

answered Sep 24, 2011 at 0:19

Charles Goodwin

6,6923 gold badges38 silver badges64 bronze badges

Collectives™ on Stack Overflow

Forcing JavaScript return false to persist through functions

2 Answers 2

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related