javascript return false; is not working on each function

Question

I have mentioned my code below, i have a problem with return flase; inside a javascript each function

$(".current_patient_medicine").each(function (i) {
    var id = this.id;
    var value = $("#" + id).val();
    if (value.trim() == "") {

        check = false;
        alert("Medicine Name cannot left Blank.");
        return false;
    } else {
        check = true;
    }
});
$(".current_patient_medicine_days").each(function (i) {
    var id = this.id;
    var value = $("#" + id).val();
    if (value.trim() == "") {

        check = false;
        alert("Days Field cannot left Blank.");
        return false;
    } else {
        check = true;
    }
});

here the first condition alert "Medicine Name cannot left blank" showing well but after that the second alert also showing

Use break instead of return false if you don't want to make other loops. — pavel
– pavel, Commented Feb 17, 2015 at 7:04
Nitpick: your code's indentation makes it difficult to read. Have a look at a Javascript style guide — Just Jake
– Just Jake, Commented Feb 17, 2015 at 7:05
break must be inside a loop or switch, so it's throwing javascrip error — askm3
– askm3, Commented Feb 17, 2015 at 7:06
@panther: you can't use a break statent here because this isn't a Javascript loop construct like for or while. .each in jQuery is a higher-order function; break is an illegal statement in this context: cl.ly/image/0M3C1o0P280T/… — Just Jake
– Just Jake, Commented Feb 17, 2015 at 7:08

Arun P Johny · Accepted Answer · 2015-02-17 07:25:44Z

You have the return false in an inner function call, it wouldn't stop the execution flow of the external function so you need

var check = true;
$(".current_patient_medicine").each(function (i) {
    var value = this.value;
    if (value.trim() == "") {
        check = false;
        alert("Medicine Name cannot left Blank.");
        return false;
    }
});
if (!check) {
    return false;
}
$(".current_patient_medicine_days").each(function (i) {
    var value = this.value;
    if (value.trim() == "") {
        check = false;
        alert("Days Field cannot left Blank.");
        return false;
    }
});
if (!check) {
    return false;
}

$('button').click(function() {
  var check = true;
  $(".current_patient_medicine").each(function(i) {
    var value = this.value;
    if (value.trim() == "") {
      check = false;
      alert("Medicine Name cannot left Blank.");
      return false;
    }
  });
  if (!check) {
    return false;
  }
  $(".current_patient_medicine_days").each(function(i) {
    var value = this.value;
    if (value.trim() == "") {
      check = false;
      alert("Days Field cannot left Blank.");
      return false;
    }
  });
  if (!check) {
    return false;
  }
})

<script src="https://ajax.googleapis.com/ajax/libs/jquery/1.11.1/jquery.min.js"></script>
<input id="m1" class="current_patient_medicine" />
<input id="d1" class="current_patient_medicine_days" />
<br />
<input id="m2" class="current_patient_medicine" />
<input id="d2" class="current_patient_medicine_days" />
<br />
<button>Test</button>

Shadi Alnamrouti · Accepted Answer · 2018-01-22 07:50:49Z

2

Rule of thumb: avoid return statements inside $.each statements

Rethink the solution:

function logic(someArray)
{
    var result = false;
    $.each(someArray, function(index,item){

        if(item == someValue)
        {
           result = true;
        }

    });

    return result;
}

This problem costed me a complete day to discover and fix. OMG!

Hope This helps someone.

answered Jan 22, 2018 at 7:50

Shadi Alnamrouti

13.6k5 gold badges62 silver badges56 bronze badges

1 Comment

Urvah Shabbir Over a year ago

so many answers telling where to put the correct return false statement. But nothing worked since the problem was the logic and NOT the implementation. This saved my day. Thank you.

Just Jake · Accepted Answer · 2015-02-17 07:28:09Z

Check out the documentation for $.each():

We can break the $.each() loop at a particular iteration by making the callback function return false. Returning non-false is the same as a continue statement in a for loop; it will skip immediately to the next iteration.

I've slightly simplified your codez:

var check = true;

$(".current_patient_medicine").each(function() {
  // The empty string ("") is falsey, so we can remove the comparison.
  // Also, no need to double-select the current element,
  // instead get the val() directly:
  if (! $(this).val().trim()) {
    alert("Medicine Name cannot left Blank.");
    check = false;
    return false;
  }
});

$(".current_patient_medicine_days").each(function() {
  if (! $(this).val().trim()) {
    alert("Days Field cannot left Blank.");
    check = false;
    return false;
  }
});

This code will alert the first time it sees an empty .current_patient_medicine value, and then it will alert the first time it sees an empty .current_patient_medicine_days value.

Collectives™ on Stack Overflow

javascript return false; is not working on each function

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

Comments

Your Answer

Sign up or log in

Post as a guest

Related