Nested for loop with if statement in batch file

Question

I know this question might have already been discussed a thousands of times but I dont know what am I doing wrong!

I have the following bat file script that tries to perform a memory dump based on PID of all the current processes matched by the %PROCNAME% variable. It seem to perform what I need upto the point where I echo the %DUMFILENAME%. Here it prints the PID of the previous iteration's PID variable ...

E.g. If I have 3 notepad instances (with PIDs 1, 2, 3) running and I run the following bat. I get following output on command prompt:

"Current PID is 1"

C:\Documents and Settings\userme\Local Settings\Application Data\notepad\notepad.exe_Thu 03222012204843.02.dmp

"Current PID is 2"

C:\Documents and Settings\userme\Local Settings\Application Data\notepad\notepad.exe_1_Thu 03222012204843.02.dmp

"Current PID is 3"

C:\Documents and Settings\userme\Local Settings\Application Data\notepad\notepad.exe_2_Thu 03222012204843.02.dmp

My bat script:

@echo off
SETLOCAL EnableDelayedExpansion
SET PROCNAME=notepad.exe
FOR /F "tokens=1 delims=," %%A in ('tasklist /FI "IMAGENAME eq %PROCNAME%" /FO LIST') DO (
      set "maintoken=%%A"
      Call:InnerToken !maintoken!)
pause
goto :end
:InnerToken
set innertoken=%1
IF "%innertoken%"=="PID:" (
      FOR /F "tokens=1,2 delims=:" %%B in ("%innertoken%") DO (
         set "res=%~n2"
         echo "Current PID is !res!"
         SET "DUMPFILENAME=%USERPROFILE%\Local Settings\Application Data\Notepad\%PROCNAME%_!res!_%date:/=%%time::=%.dmp"
         echo %DUMPFILENAME%
         )
      )
:end

Any help would be greatly appreciated...

Joey · Accepted Answer · 2012-03-22 16:11:07Z

2

Use

echo !DUMPFILENAME!

instead.

Which surprises me though, as you seem to already know that you need delayed expansion when setting and using variables in blocks.

answered Mar 22, 2012 at 16:11

Joey

357k88 gold badges705 silver badges700 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Vinit Sankhe Over a year ago

So does that mean when I use a a delayed expanded variable like !res! to create another local variable such as DUMPFILENAME I am supposed treat DUMPFILENAME also as a delayed expansion variable? I really didnt know this.

Joey Over a year ago

cmd isn't a spreadsheet and won't track where your variables got its values. Delayed expansion is necessary because variables are expanded when parsing a statement (which, if it is or includes a block, counts as a single statement).

Collectives™ on Stack Overflow

Nested for loop with if statement in batch file

1 Answer 1

2 Comments

Your Answer

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Your Answer

Sign up or log in

Post as a guest

Related