Changeset 124671 in webkit for trunk/Source/WebCore/rendering/RenderGrid.h

Timestamp:

Aug 3, 2012, 4:36:05 PM (13 years ago)

Author:

jchaffraix@webkit.org

Message:

Implement computePreferredLogicalWidths on RenderGrid
​https://bugs.webkit.org/show_bug.cgi?id=92908

Reviewed by Ojan Vafai.

Source/WebCore:

This functions implements a primitive computePreferredLogicalWidths
so that we properly handle vertical writing modes.

Covered by fast/css-grid-layout/place-cell-by-index.html.

• rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredLogicalWidths):

• rendering/RenderGrid.h:

Added computePreferredLogicalWidths.

LayoutTests:

• fast/css-grid-layout/place-cell-by-index-expected.txt:

Updated the expected file (everything passes now).

• fast/css-grid-layout/place-cell-by-index.html:

Removed some FIXMEs and added one about the expected offsets making
a wrong assumption. It's fine to keep this testing until we support
this part of the spec.

File:

• trunk/Source/WebCore/rendering/RenderGrid.h (modified) (1 diff)

trunk/Source/WebCore/rendering/RenderGrid.h

@@ -39 +39 @@
 
     virtual void layoutBlock(bool relayoutChildren, LayoutUnit pageLogicalHeight = 0) OVERRIDE;
+    virtual void computePreferredLogicalWidths() OVERRIDE;
 
     virtual bool avoidsFloats() const OVERRIDE { return true; }