Changeset 196978 in webkit for trunk/Source/WebCore/ChangeLog


Ignore:
Timestamp:
Feb 23, 2016, 8:49:54 AM (10 years ago)
Author:
Manuel Rego Casasnovas
Message:

[css-grid] Rows track sizes are optional in grid-template shorthand
https://bugs.webkit.org/show_bug.cgi?id=154586

Reviewed by Sergio Villar Senin.

You can omit the size of the rows in grid-template shorthand,
even if you specify a named grid line for the end of the row,
due to a change in the spec back in 2014:
https://github.com/w3c/csswg-drafts/commit/9f660c4183c73c1f5279c46904dc6cb314f76194

Before if you want to specify a named grid line,
you need to set the row size.

Update parsing, so it nows accepts things like:

grid-template: 100px / "a" [bottom];

Source/WebCore:

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateRowsAndAreasAndColumns):
(WebCore::CSSParser::parseGridTemplateShorthand):

File:
1 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r196977 r196978  
     12016-02-23  Manuel Rego Casasnovas  <rego@igalia.com>
     2
     3        [css-grid] Rows track sizes are optional in grid-template shorthand
     4        https://bugs.webkit.org/show_bug.cgi?id=154586
     5
     6        Reviewed by Sergio Villar Senin.
     7
     8        You can omit the size of the rows in grid-template shorthand,
     9        even if you specify a named grid line for the end of the row,
     10        due to a change in the spec back in 2014:
     11        https://github.com/w3c/csswg-drafts/commit/9f660c4183c73c1f5279c46904dc6cb314f76194
     12
     13        Before if you want to specify a named grid line,
     14        you need to set the row size.
     15
     16        Update parsing, so it nows accepts things like:
     17            grid-template: 100px / "a" [bottom];
     18
     19        * css/CSSParser.cpp:
     20        (WebCore::CSSParser::parseGridTemplateRowsAndAreasAndColumns):
     21        (WebCore::CSSParser::parseGridTemplateShorthand):
     22
    1232016-02-23  Nikos Andronikos  <nikos.andronikos-webkit@cisra.canon.com.au>
    224
Note: See TracChangeset for help on using the changeset viewer.