Can't get default values to work with custom shortcode

Question

I'm working on creating a shortcode to embed locally hosted Quicktime movies, but I can't seem to get the default attributes to stick. Here's what I'm working with, can anyone spot anything obviously wrong? The result gives me no value for an unspecified attribute at all (in this case height/width), rather than the desired defaults of 480 and 320. If specified, it works as intended.

<?php
function quicktime_embedder( $atts, $content = null ) {
    extract( shortcode_atts( array(
        'url' => '#',
        'width' => '480',
        'height' => '320'
    ), $atts ) );

    return '<object classid="clsid:02BF25D5-8C17-4B23-BC80-D3488ABDDC6B"
                codebase="http://www.apple.com/qtactivex/qtplugin.cab" height="300" width="500">
                <param name="src" value="http://www.yoursite.com/video/video1.mov">
                <param name="autoplay" value="false">
                <param name="controller" value="true">
                <param name="type" value="video/quicktime" height="'.$atts[height].'" width="'.$atts[width].'">
                <embed src="'.$atts[url].'"
                     height="'.$atts[height].'" width="'.$atts[width].'" autoplay="false" type="video/quicktime"
                 pluginspage="http://www.apple.com/quicktime/download/">
            </object>';
}

add_shortcode( 'quicktime', 'quicktime_embedder' );

?>

chrisguitarguy · Accepted Answer · 2011-08-29 12:48:06Z

0

extract takes and associative array and explodes it out in variables that reflect the array key names. $atts['height'] would just be $height, in other words.

The relevant two lines of your code would become:

<param name="type" value="video/quicktime" height="'.$height.'" width="'.$width.'">
<embed src="'.$url.'" height="'.$height.'" width="'.$width.'" autoplay="false" type="video/quicktime" pluginspage="http://www.apple.com/quicktime/download/">

If you did still want to use the indexing, make sure you surround array keys with quotes: $atts['height'] not $atts[height]. Replace extract:

$atts = shortcode_atts( array(
        'url' => '#',
        'width' => '480',
        'height' => '320'
    ), $atts )

answered Aug 29, 2011 at 12:48

chrisguitarguy

21.6k5 gold badges63 silver badges99 bronze badges

Perfect! I didn't understand extract correctly. That got me exactly what I needed, thank you so much!

Dan G.
– Dan G.

2011-08-29 13:05:54 +00:00
Commented Aug 29, 2011 at 13:05

Add a comment |

Stack Exchange Network

Can't get default values to work with custom shortcode

1 Answer 1

Your Answer

Hot Network Questions

Can't get default values to work with custom shortcode

1 Answer 1

Your Answer

Sign up or log in

Post as a guest

Related

Hot Network Questions