Remove comma from last item output from loop

Question

(or add comma to all items but the last one...)

Most of the information I have found relates to using a counter within a foreach loop. In this particular situation I am using Advanced Custom Fields and I am within a standard loop, not a foreach loop.

I need to add a comma to the end of each item except the last.

<?php while( has_sub_field('images') ): ?>
    <?php $image = wp_get_attachment_image_src(get_sub_field('image'), 'wsn_canvas'); ?>
    <?php echo $image[0]; ?>
    //echo comma here
<?php endwhile; ?>

$output = $image[0] .','; endwhile; $output = substr_replace($output ,"",-1); echo $output; ?? you can also get rid of all your php tags .. you have no HTML in there. — krembo99
– krembo99, Commented Apr 21, 2013 at 4:24

s_ha_dum · Accepted Answer · 2013-04-21 04:25:18Z

There is nothing 'standard' about a while loop and in this case it makes things harder, since you need a total count of all the items in loop in order to know if you are on the last item or not. It is not obvious how to get that total count with a function like has_sub_field but there is a quick way to do this that I use fairly often to build character separated strings when I don't know how many items will be in the final result.

$attach = array();
while( has_sub_field('images') ):
    $image = wp_get_attachment_image_src(get_sub_field('image'), 'wsn_canvas');
    $attach[] = $image[0];
endwhile;
echo implode(', ',$attach);

fuxia · Accepted Answer · 2013-04-21 09:37:11Z

Use wp_sprintf_l( $pattern, $args ):

$images = array();

while( has_sub_field('images') )
{
    $image = wp_get_attachment_image_src(get_sub_field('image'), 'wsn_canvas');
    $images[] = $image[0];
}

if ( ! empty ( $images ) )
    echo wp_sprintf_l( '%l', $images );

This will use localized separators, an Arabic comma between the items for Arabic for example.

The separator for the last two items is by default ', and ' (Oxford comma), but you can change that too with a filter:

add_filter( 'wp_sprintf_l', 'replace_oxford_comma' );

function replace_oxford_comma( $separators )
{
    $separators['between_last_two'] = ' and';
    return $separators;
}

Community · Accepted Answer · 2017-05-23 12:40:07Z

1

It's also possible to create comma separated lists with a terminal 'and' (Oxford style or not) using only CSS: https://stackoverflow.com/questions/6587807/comma-delimited-lists-with-css-i-want-an-oxford-comma

edited May 23, 2017 at 12:40

CommunityBot

1

answered Jul 24, 2014 at 16:49

Dan Knauss

1398 bronze badges

Add a comment |

Stack Exchange Network

Remove comma from last item output from loop

3 Answers 3

Your Answer

Linked

Hot Network Questions

Remove comma from last item output from loop

3 Answers 3

Your Answer

Sign up or log in

Post as a guest

Linked

Related

Hot Network Questions