Skip to content

Conversation

@melloware
Copy link

@melloware melloware commented Dec 8, 2025

Fix #363: CVE-2025-66021

  • 4 unit tests that failed before the fix now pass
  • All existing unit tests pass (had to make some Windows fixes)
  • New code checks any element with allowTextIn to make sure it allows only tags allowed

@melloware melloware force-pushed the O363-CVE branch 4 times, most recently from 1fba743 to e3d1cc0 Compare December 8, 2025 20:54
@melloware melloware marked this pull request as ready for review December 8, 2025 20:54
StandardCharsets.UTF_8)).lines().collect(Collectors.joining());
String html = new String(Files.readAllBytes(
Paths.get(getClass().getResource("/benchmark-data/Yahoo!.html").toURI())),
StandardCharsets.UTF_8);
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests were failing on Windows

// Do the lexing.
String input = new String(Files.readAllBytes(Paths.get(getClass().getResource("htmllexerinput1.html").toURI())), StandardCharsets.UTF_8);
// Normalize line endings in input to handle Windows/Unix differences
input = input.replace("\r\n", "\n").replace("\r", "\n");
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests were failing on Windows

@melloware
Copy link
Author

cc @ironfisto

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Vulnerabilities: CVE-2025-66021

1 participant