fix: make app failed if a container is stopped #116
+47
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9be4ebb to
1bfe213
Compare
lucarin91
reviewed
Nov 27, 2025
dc07a7f to
09691b6
Compare
lucarin91
reviewed
Nov 28, 2025
Contributor
|
we should think of some test for this |
lucarin91
requested changes
Nov 28, 2025
| containerState: []container.ContainerState{container.StateRunning, container.StateDead, container.StateRemoving, container.StateRestarting, container.StateExited}, | ||
| want: StatusFailed, | ||
| }, | ||
| { |
Contributor
There was a problem hiding this comment.
we should add a test for the new check
Contributor
Author
There was a problem hiding this comment.
Created as status failed!
i've also added statusMessage string example inspired by some real cases
3db2a77 to
0243557
Compare
Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>
0243557 to
2549af2
Compare
lucarin91
requested changes
Dec 5, 2025
2549af2 to
a09d652
Compare
lucarin91
requested changes
Dec 5, 2025
lucarin91
reviewed
Dec 5, 2025
9b7128a to
fbcc770
Compare
fbcc770 to
fe0cced
Compare
lucarin91
reviewed
Dec 15, 2025
lucarin91
reviewed
Dec 15, 2025
lucarin91
reviewed
Dec 15, 2025
339d18c to
09a7e8b
Compare
09a7e8b to
acba544
Compare
lucarin91
approved these changes
Dec 22, 2025
| return StatusStopped | ||
| case container.StateExited: | ||
| if !isExitBySignal(statusMessage) { | ||
| return StatusFailed |
Contributor
There was a problem hiding this comment.
Suggested change
| return StatusFailed | |
| // The app exited on its own, which we consider a failure. | |
| return StatusFailed |
| return StatusStopped | ||
| case container.StateDead: | ||
| return StatusFailed | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If at least a container of an application is stopped due to any reason, the application status should be failed.
In this way even if other containers are up and running the state of the application state is set as failed, and the user can debug the failed container.