feat: remote camera validation rule #171
Draft
+13
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xayton
reviewed
Dec 22, 2025
| if len(requiredDeviceClasses) > 0 { | ||
| for class := range requiredDeviceClasses { | ||
| switch class { | ||
| case RemoteCameraDevice: |
Contributor
There was a problem hiding this comment.
This means that the App will run and eventually fail in the brick code, when the remote device is not found, right?
If so, what does having a remote_camera and remote_microphone add to the experience?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To support mobile companion app, we need to start introducing new device types to support remote devices.
Reviewer checklist
main.