wip: support sending blobs #17
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
This approach is necessary. Will try playing around with JavaScript-driven approach now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is work in progress.
I need to pair this with a test blob implementation in a different module, e.g.
fs, to see its potential real-life usage.Specification doesn't mention awaiting arrayBuffer, but instead, that is natively and efficiently supported. I am thinking while this naive approach works, having Blob as a HybridObject would make a bit more sense.
In fact, it could be a C++ API where all that slice etc., logic is shared, and we can have nicer streaming. I have to think about it, ideas are welcome, instead, just dropping this PR.