feat: initial implementation of FileAccess API #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grabbou
commented
Nov 8, 2024
Collaborator
Author
|
Need to implement directory, other picker types and options, but this is looking good-ish. |
Collaborator
Author
|
Going to move ahead and merge it, but please provide a review anyway and we will follow-up later! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FilePicker (#23)
FileSystemFileHandle
Moving all polyfills to user land
Using TypeScript DOM type definitions (that are generated off the specification). Note that TypeScript definitions only support features that are covered by at least two browser engines. That's why certain methods are not there.
We should revisit this approach in the future (whether we want to support entire specification, or just the widely adopted methods), but I guess it will do for now.