Skip to content

Update deps and fix test failed from using Puppeteer #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 13, 2020
Merged

Update deps and fix test failed from using Puppeteer #5

merged 4 commits into from
Nov 13, 2020

Conversation

@lukyth
Copy link
Contributor

@lukyth lukyth commented Oct 19, 2020

This PR does three things

  • Remove yarn.lock since it says npm i in the Readme.md, and package-lock.json already exist
  • Update dependencies
  • Fix test failed from codecept.conf.js and steps.d.ts still reference Puppeteer. It says CodeceptJS + Playwright in the Readme.md so I figured it should be Playwright instead.

@DavertMik
Copy link
Contributor

DavertMik commented Nov 13, 2020

Thank you!

@DavertMik DavertMik merged commit 4c591f2 into codeceptjs:master Nov 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lukyth @DavertMik