Merge pull request rails#26630 from kamipo/quoted_binary

Extract `quoted_binary` and use it rather than override `_quote`

Author: rafaelfranca

activerecord/lib/active_record/connection_adapters/abstract/quoting.rb

@@ -141,6 +141,10 @@ def quoted_time(value) # :nodoc:
         quoted_date(value).sub(/\A2000-01-01 /, "")
       end
 
+      def quoted_binary(value) # :nodoc:
+        "'#{quote_string(value.to_s)}'"
+      end
+
       private
 
         def type_casted_binds(binds)
@@ -153,14 +157,15 @@ def types_which_need_no_typecasting
 
         def _quote(value)
           case value
-          when String, ActiveSupport::Multibyte::Chars, Type::Binary::Data
+          when String, ActiveSupport::Multibyte::Chars
             "'#{quote_string(value.to_s)}'"
           when true       then quoted_true
           when false      then quoted_false
           when nil        then "NULL"
           # BigDecimals need to be put in a non-normalized form and quoted.
           when BigDecimal then value.to_s("F")
           when Numeric, ActiveSupport::Duration then value.to_s
+          when Type::Binary::Data then quoted_binary(value)
           when Type::Time::Value then "'#{quoted_time(value)}'"
           when Date, Time then "'#{quoted_date(value)}'"
           when Symbol     then "'#{quote_string(value.to_s)}'"

activerecord/lib/active_record/connection_adapters/mysql/quoting.rb

@@ -36,15 +36,9 @@ def quoted_date(value)
           end
         end
 
-        private
-
-          def _quote(value)
-            if value.is_a?(Type::Binary::Data)
-              "x'#{value.hex}'"
-            else
-              super
-            end
-          end
+        def quoted_binary(value)
+          "x'#{value.hex}'"
+        end
       end
     end
   end

activerecord/lib/active_record/connection_adapters/postgresql/quoting.rb

@@ -55,6 +55,10 @@ def quoted_date(value) #:nodoc:
           end
         end
 
+        def quoted_binary(value) # :nodoc:
+          "'#{escape_bytea(value.to_s)}'"
+        end
+
         def quote_default_expression(value, column) # :nodoc:
           if value.is_a?(Proc)
             value.call
@@ -76,8 +80,6 @@ def lookup_cast_type_from_column(column) # :nodoc:
 
           def _quote(value)
             case value
-            when Type::Binary::Data
-              "'#{escape_bytea(value.to_s)}'"
             when OID::Xml::Data
               "xml '#{quote_string(value.to_s)}'"
             when OID::Bit::Data

activerecord/lib/active_record/connection_adapters/sqlite3/quoting.rb

@@ -18,15 +18,11 @@ def quoted_time(value)
           quoted_date(value)
         end
 
-        private
+        def quoted_binary(value)
+          "x'#{value.hex}'"
+        end
 
-          def _quote(value)
-            if value.is_a?(Type::Binary::Data)
-              "x'#{value.hex}'"
-            else
-              super
-            end
-          end
+        private
 
           def _type_cast(value)
             case value