-
-
Notifications
You must be signed in to change notification settings - Fork 302
docs(exit-codes): general update and add docstring to exceptions.py #1662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1662 +/- ##
==========================================
Coverage ? 98.67%
==========================================
Files ? 60
Lines ? 2647
Branches ? 0
==========================================
Hits ? 2612
Misses ? 35
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bf1fca1 to
08f521a
Compare
08f521a to
b7b09bc
Compare
commitizen/exceptions.py
Outdated
|
|
||
|
|
||
| class CurrentVersionNotFoundError(CommitizenException): | ||
| """current version cannot be found in _version_files_""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| """current version cannot be found in _version_files_""" | |
| """Current version cannot be found in `version_files`""" |
docs/exit_codes.md
Outdated
| | `CurrentVersionNotFoundError`| 17 | Current version cannot be found in _version_files_ | | ||
| | `InvalidCommandArgumentError`| 18 | The argument provided to the command is invalid (e.g. `cz check -commit-msg-file filename --rev-range master..`) | | ||
| | `InvalidConfigurationError` | 19 | An error was found in the Commitizen Configuration, such as duplicates in `change_type_order` | | ||
| | `NotAllowed` | 20 | `--incremental` cannot be combined with a `rev_range` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it the only case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. I can update the description like "Invalid combination of command line / configuration file options"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it would be better if we do that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
|
nice! LGTM! |
b7b09bc to
3b1a00c
Compare
docs(exception): add comment for updating exit code doc
3b1a00c to
53f2496
Compare
Update outdated information, fix grammar mistakes, add error codes, etc.