-
-
Notifications
You must be signed in to change notification settings - Fork 302
fix(version): fix the behavior of cz version --major
#1673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: v4-10-1
Are you sure you want to change the base?
fix(version): fix the behavior of cz version --major
#1673
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-10-1 #1673 +/- ##
==========================================
Coverage ? 98.67%
==========================================
Files ? 60
Lines ? 2649
Branches ? 0
==========================================
Hits ? 2614
Misses ? 35
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5229525 to
8f6491b
Compare
8f6491b to
d05067c
Compare
|
Shouldn't this scenario fail? But the way I was picturing it was:
which translates to I think users would want to work withe the project's version, if you want your project's next version: By allowing I agree that right now it's a bogus scenario: |
|
Sounds good, then I will make it fail in the next iteration. Failing the command sounds better |
|
How about showing the help of |
6e9cfaa to
cb92f16
Compare
woile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cb92f16 to
40b2251
Compare
|
I moved the no argument |
|
I just rebase the |
05fc0a3 to
d40e9f2
Compare
|
Also updated PR description. |
Description
Fixed the behavior of
--majorand--minor. Added tests.Before this PR
cz version --major # 4.10.0After this PR
cz version --major # Output errors about wrong usage of `cz version`Also added the expected usage for
--majorand--minoroptions.Checklist
Code Changes
poetry alllocally to ensure this change passes linter check and tests