-
Notifications
You must be signed in to change notification settings - Fork 803
P3567R2 flat_meow fixes
#8524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
P3567R2 flat_meow fixes
#8524
Conversation
|
There's no need for an issue, the intended design is clear: they should all be constexpr. Please just add constexpr keywords as a fixup commit. |
Yes, please. |
|
Alright, I've made them all |
| $N$ + $M \log M$, where $N$ is \tcode{size()} before the operation and $M$ | ||
| is \tcode{ranges::distance(rg)}. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $N$ + $M \log M$, where $N$ is \tcode{size()} before the operation and $M$ | |
| is \tcode{ranges::distance(rg)}. | |
| $N$ + $M \log M$, where $N$ is \tcode{size()} before the operation | |
| and $M$ is \tcode{ranges::distance(rg)}. |
(semantic break)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The chosen line break is consistent with what we have further up for flat_map::insert and further below for flat_set::insert.
The and here is also a conjunction in a list, so it seems more appropriate to put it at the end of the line.
These functions are not marked constexpr in P3567R2, but the intent of the (already merged) P3372R3 is to mark all member functions constexpr.
73480c2 to
b6d9c10
Compare
|
Should be all fixed now. Had to force-push because the second commit which adds |
Fixes #8463
No NB comment.
Also fixes cplusplus/papers#2211
PROBLEM: cplusplus/papers#2029 added
constexprto the members offlat_meow, but what we're merging doesn't have anyconstexpron it. LWG issue? @jwakely