P3815R1 Add scope_association concept to P3149 #8531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes NB FI-392, CA-393 (C++26 CD).
eisenwave
suggested changes
Nov 15, 2025
jwakely
requested changes
Nov 28, 2025
| @\exposid{sndr}@.reset(); | ||
| @\exposid{assoc}@([&] { | ||
| @\exposid{sender-ref}@ guard{addressof(@\exposid{sndr}@)}; | ||
| auto assoc = t.try_associate(); |
Member
There was a problem hiding this comment.
Should we choose a different name for this local variable 'assoc' which doesn't shadow the data member assoc?
source/exec.tex
Outdated
Comment on lines
5079
to
5080
| : assoc(std::move(parts.first)) { | ||
| if (assoc) |
Member
There was a problem hiding this comment.
Suggested change
| : assoc(std::move(parts.first)) { | |
| if (assoc) | |
| : @\exposid{assoc}@(std::move(parts.first)) { | |
| if (@\exposid{assoc}@) |
source/exec.tex
Outdated
| if (assoc) | ||
| ::new (@\placeholdernc{voidify}@(op)) op_t(connect(std::move(*parts.second), std::move(r))); | ||
| else | ||
| rcvr = addressof(r); |
Member
There was a problem hiding this comment.
Suggested change
| rcvr = addressof(r); | |
| @\exposid{rcvr}@ = addressof(r); |
source/exec.tex
Outdated
| explicit op_state(pair<assoc_t, sender_ref_t> parts, Rcvr& r) | ||
| : assoc(std::move(parts.first)) { | ||
| if (assoc) | ||
| ::new (@\placeholdernc{voidify}@(op)) op_t(connect(std::move(*parts.second), std::move(r))); |
Member
There was a problem hiding this comment.
Suggested change
| ::new (@\placeholdernc{voidify}@(op)) op_t(connect(std::move(*parts.second), std::move(r))); | |
| ::new (@\placeholdernc{voidify}@(@\exposid{op}@)) op_t(connect(std::move(*parts.second), std::move(r))); |
source/exec.tex
Outdated
| \pnum | ||
| \exposid{association-t} is a class template, | ||
| specializations of which model \libconcept{scope_association} and | ||
| contain an exposition-only member scope of type \tcode{Scope*}. |
Member
There was a problem hiding this comment.
Suggested change
| contain an exposition-only member scope of type \tcode{Scope*}. | |
| contain an exposition-only member \exposid{scope} of type \tcode{Scope*}. |
source/exec.tex
Outdated
| \tcode{assoc} is engaged when \tcode{assoc.\exposid{scope} != nullptr} is \tcode{true}, | ||
| \item | ||
| if \tcode{assoc} is engaged, | ||
| then \tcode{assoc.\exposid{try_associate}()} is equivalent to |
Member
There was a problem hiding this comment.
Suggested change
| then \tcode{assoc.\exposid{try_associate}()} is equivalent to | |
| then \tcode{assoc.try_associate()} is equivalent to |
Looks like you put the \exposid here, when it should have been on the line below.
source/exec.tex
Outdated
| \tcode{assoc.scope->try-associate()}, and | ||
| \item | ||
| the association owned by \tcode{assoc} | ||
| is released by invoking \tcode{assoc.scope->\exposid{disassociate}()}. |
Member
There was a problem hiding this comment.
Suggested change
| is released by invoking \tcode{assoc.scope->\exposid{disassociate}()}. | |
| is released by invoking \tcode{assoc.\exposid{scope}->\exposid{disassociate}()}. |
| // \ref{exec.simple.counting.token}, token | ||
| struct token; | ||
|
|
||
| using @\exposid{assoc-t}@ = @\exposid{association-t}@<simple_counting_scope>; // \expos |
Member
There was a problem hiding this comment.
Suggested change
| using @\exposid{assoc-t}@ = @\exposid{association-t}@<simple_counting_scope>; // \expos | |
| // \ref{exec.simple.counting.assoc}, assoc | |
| using @\exposid{assoc-t}@ = @\exposid{association-t}@<simple_counting_scope>; // \expos |
Member
Author
There was a problem hiding this comment.
That label doesn't exist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes NB FI-392, CA-393 (C++26 CD).
Fixes #8475
Fixes cplusplus/papers#2426
Fixes cplusplus/nbballot#967
Fixes cplusplus/nbballot#968