Skip to content

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Nov 14, 2025

  • Apparently these work with both almost-sync backends (current HEAD) and also with Check which tests are fragile / depend on timing. #9069.
  • In most cases the change only tracks/awaits the creation of the cloud worker instance, but for some tests I needed to modify the assertion logic too.
  • Note: I think we should rewrite the scheduling logic and its async delegation (which is implemented with scheduled microtasks), exposing more control and also some event over it, in order to make these tests more readable.

@isoos isoos requested review from jonasfj and sigurdm November 14, 2025 13:17
@isoos isoos changed the title Updates task tests: working with non-synchronous backends. Updated task tests: working with non-synchronous backends. Nov 14, 2025
Comment on lines +63 to 64
await created;
await clockControl.elapse(minutes: 5);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if you did:

await Future.wait([
  created,
  await clockControl.elapse(minutes: 5),
]);

@isoos
Copy link
Collaborator Author

isoos commented Nov 14, 2025

Note: I've checked how these are behaving with the wip-typed-sql rewrite, and it now passes 5 tests out of 8, and 2 of the 3 failing is probably related to scheduling.

Before going further with this, I'll look into the ControlledClock as we've discussed offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants