Skip to content

Conversation

@daidai21
Copy link

@daidai21 daidai21 commented Aug 2, 2019

No description provided.

@ddbourgin
Copy link
Owner

Hi @daidai21 - I just took a look this PR. I see that the code is copied directly from https://github.com/LasseRegin/SVM-w-SMO/blob/master/SVM.py .

This is unacceptable.

PRs you submit should reflect earnest attempts at implementing a model yourself. To be absolutely clear: it is fine to reference others' code. It is not fine to blindly copy it without attribution -- that is plagiarism.

I appreciate that you are eager to contribute to the repo. Trust me, I want you to contribute. The key word here is you -- a pull request with a wrapper around someone else's code is not a contribution from you.

If you still want to work on this, I suggest first trying to understand the mathematics behind the model, then work towards your own implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants