Fix sparse fieldset RuntimeError under python3.5 #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Python 3.5, using sparse fieldsets causes a `RuntimeError: OrderedDict mutated during iteration`. This patch fixes the bug, in `SparseFieldsetMixin`, by iterating over a copy of the `OrderedDict`, so that the original may be modified in the loop. The `OrderedDict` in question is the underlying `OrderedDict` of the `BindingDict` returned by the `fields` property on `Serializer`. If curious, see section [4.10.1](https://docs.python.org/3/library/stdtypes.html#dictionary-view-objects) of the python standard library docs for more information about why this RuntimeError was being thrown in the first place.
jsenecal
added a commit
that referenced
this pull request
Nov 24, 2015
Fix sparse fieldset RuntimeError under python3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With Python 3.5, using sparse fieldsets causes a
RuntimeError: OrderedDict mutated during iteration.This patch fixes the bug, in
SparseFieldsetMixin, by iterating over a copy of theOrderedDict, so that the original may be modified in the loop.The
OrderedDictin question is the underlyingOrderedDictof theBindingDictreturned by thefieldsproperty onSerializer.If curious, see section 4.10.1 of the python standard library docs for more information about why this RuntimeError was being thrown in the first place.