Skip to content

[9.2] Extend reflection to retrieve vector values from DefaultFlatVectorScorer$FloatScoringSupplier too (#138503) #138743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2025
Merged

[9.2] Extend reflection to retrieve vector values from DefaultFlatVectorScorer$FloatScoringSupplier too (#138503) #138743

merged 1 commit into from
Nov 28, 2025
+24 −8

Conversation

@ldematte
Copy link
Contributor

@ldematte ldematte commented Nov 28, 2025

Backports the following commits to 9.2:

@ldematte
Extend reflection to retrieve vector values from DefaultFlatVectorSco…
9768203 
…rer$FloatScoringSupplier too (elastic#138503)

While running gpu:yamlRestTest tests, under some circumstances the scorer is not Lucene99MemorySegmentFloatVectorScorerSupplier, but DefaultFlatVectorScorer$FloatScoringSupplier. This PR extend reflection to support the "fast path" to access vector values to this class too.
@ldematte ldematte added the :Search Relevance/Vectors Vector search label Nov 28, 2025
@ldematte ldematte requested a review from a team as a code owner November 28, 2025 07:45
@ldematte ldematte added >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch labels Nov 28, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Nov 28, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit b96a568 into elastic:9.2 Nov 28, 2025
34 checks passed
@ldematte ldematte deleted the backport/9.2/pr-138503 branch November 28, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport >non-issue :Search Relevance/Vectors Vector search Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.2.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ldematte @elasticsearchmachine