Skip to content

Bug: Fix test framework issues #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Bug: Fix test framework issues #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e09c4fa
return byte, error
2hmad Apr 13, 2023
6bd0d70
fix ci error
2hmad Apr 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions context.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,8 +208,14 @@ func (c *Context) Status(code int) {
}

// JSON sets the response body to the given JSON representation.
func (c *Context) JSON(code int, obj interface{}) {
func (c *Context) JSON(code int, obj interface{}) ([]byte, error) {
c.RequestCtx.Response.Header.SetContentType("application/json")
c.RequestCtx.Response.SetStatusCode(code)
c.RequestCtx.Response.SetBodyString(utils.ToJSON(obj))
jsonBody, err := utils.ToJSON(obj)
if err != nil {
return nil, err
}
c.RequestCtx.Response.SetBodyString(jsonBody)

return []byte(jsonBody), nil
}
6 changes: 3 additions & 3 deletions utils/json.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ package utils

import "encoding/json"

func ToJSON(v interface{}) string {
func ToJSON(v interface{}) (string, error) {
b, err := json.Marshal(v)
if err != nil {
return ""
return "", err
}
return string(b)
return string(b), nil
}
2 changes: 1 addition & 1 deletion utils/json_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import (

func TestToJSON(t *testing.T) {
t.Parallel()
res := ToJSON("MY/NAME/IS/:PARAM/*")
res, _ := ToJSON("MY/NAME/IS/:PARAM/*")

fmt.Println(res)
}