Genshi support, as well as testing optional dependencies #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've spent too long straining to see subtle difference. This helps.
The Genshi treewalker was never fully updated when support for namespaces was added to treewalkers. This finally fixes this, allowing all tests to once again pass. This removes the ignoring of children of void elements as the commonly used treewalkers don't support this and there was some subtle bug I couldn't see in the code. Given most don't support this, this seems like little loss. (You will, however, still get an error from the treewalker if a void element has children.)
This is a simple issue of using `str` to refer to what should be `six.text_type`.
As the comment says, I am well aware how evil this is hardcoding the Debian URL, but this allows for testing of all supported optional extras, and given chardet is packaged for Python 3 in varies places, this seems worthwhile to support.
Member
Author
|
Manually rebased and merged. |
gsnedders
added a commit
to gsnedders/html5lib-python
that referenced
this pull request
Nov 24, 2014
Double-escape a troublesome tokenizer test. U+FEFF apparently doesn't decode nicely from JSON under Ruby 2.0 and Obj-C/Cocoa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please don't merge this. Let us tidy up history first.