Fix #6 by rewriting dom2sax as a "treeadapter" #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This should probably have more tests added, checking we handle namespaced attributes and foreign content correctly. |
This moves the functionality to a new treeadapters module (where later the adapters from test_treewalker.py will get moved) and removes the previous dom2sax function.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tree adapters are the new cool thing. Based on the adapters in test_treewalker.py, they take a treewalker and adapt a stream of tokens to something else. The adapters from test_treewalker.py should be moved over to be treeadapters eventually.