Fix #51: DataLossWarning hiding real exceptions in parser. #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we stopped parser tests once DataLossWarning was raised; we now run let the parser run to completion before checking for raised warnings. This hid several cases of where real exceptions were raised after DataLossWarning was raised. This commit reveals these real exceptions in the testsuite and fixes current failure. Similar fixes are needed for the other tests.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we stopped parser tests once DataLossWarning was raised; we
now run let the parser run to completion before checking for raised
warnings. This hid several cases of where real exceptions were raised
after DataLossWarning was raised. This commit reveals these real
exceptions in the testsuite and fixes current failure.
Similar fixes are needed for the other tests.