-
-
Notifications
You must be signed in to change notification settings - Fork 113
Introduction callbacks #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduction callbacks #133
Conversation
|
Nildo Júnior seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi @nildo could you please resolve the conflicts? Thank you. |
odsantos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @nildo please, have you tested the code (as much as possible) as the author suggests?
Not an imperative, but having time that might be helpful.
I hope that you might let me know if you don't agree with any change.
Thank you,
Osvaldo.
|
Please make the requested changes. After it, add a comment "/done". |
|
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Olá @nildo, segue minha revisão!
|
Please make the requested changes. After it, add a comment "/done". |
|
Hi @nildo , the English article was updated and this PR has conflicts. Thanks. |
gabifs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
@nazarepiedady I had to resolve conflicts here, could you please review it? |
nazarepiedady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is good for now, let's go ahead with these translations. @gabifs
Thanks your time.
de246b0
into
javascript-tutorial:master
No description provided.