Skip to content

Conversation

@nildo
Copy link
Contributor

@nildo nildo commented May 18, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 18, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ nildo
✅ gabifs
✅ odsantos
❌ Nildo Júnior


Nildo Júnior seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@odsantos
Copy link
Contributor

odsantos commented Dec 7, 2020

Hi @nildo could you please resolve the conflicts? Thank you.

Copy link
Contributor

@odsantos odsantos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @nildo please, have you tested the code (as much as possible) as the author suggests?
Not an imperative, but having time that might be helpful.

I hope that you might let me know if you don't agree with any change.

Thank you,
Osvaldo.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@nildo
Copy link
Contributor Author

nildo commented Aug 6, 2022

/done

Copy link
Contributor

@jonnathan-ls jonnathan-ls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olá @nildo, segue minha revisão!

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review 👻

@odsantos
Copy link
Contributor

Hi @nildo , the English article was updated and this PR has conflicts. Thanks.

@nazarepiedady
Copy link
Member

@gabifs

Copy link
Contributor

@gabifs gabifs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gabifs gabifs requested a review from jonnathan-ls November 26, 2025 22:45
@gabifs
Copy link
Contributor

gabifs commented Nov 26, 2025

@nazarepiedady I had to resolve conflicts here, could you please review it?

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good for now, let's go ahead with these translations. @gabifs

@nazarepiedady nazarepiedady dismissed stale reviews from odsantos and jonnathan-ls November 27, 2025 09:24

Thanks your time.

@nazarepiedady nazarepiedady merged commit de246b0 into javascript-tutorial:master Nov 27, 2025
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants