-
-
Notifications
You must be signed in to change notification settings - Fork 113
JavaScript Animations #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JavaScript Animations #136
Conversation
|
Please make the requested changes. After it, add a comment "/done". |
|
Hi, Karla! Doing fine? Please don't translate or change the source code in the examples. Could you take a look into that? Like, you should keep the ';', spaces and variable names. Cheers! |
Hey, yeah. I'm addressing feedback now. My linter changed the code, fixing that :) |
|
/done |
|
Hi @karlasamantha would you please also resolve the conflicts, or kindly inform if unavailable to? Thank you. |
|
Hi @karlasamantha , please I wonder if you could resolve the conflicts, or kindly inform if unavailable to? Thank you. |
Hi @odsantos , sorry for the delay! I'll try to fix the conflicts today! |
|
/done |
|
/done |
|
Hi @karlasamantha , thank you. |
odsantos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @karlasamantha ,
The article review is still missing, hopefully to another time.
Please, feel free to leave a note on something you may not agree.
Thank you.
|
Please make the requested changes. After it, add a comment "/done". |
7c7e1a4 to
c1f4878
Compare
|
/done |
|
@odsantos, @jonnathan-ls, @peruibeloko, what do you recommend colleagues to be done in this pull request? |
|
@karlasamantha, are you available to update and apply the changes requested? |
@nazarepiedady sure, but I don't see any pending changes requested. Am I missing something here? |
|
@karlasamantha, I would like to invite you to compare the original English content to the Portuguese content translated by you to see if there are any updates needed or sentences that need to be applied. I also invite you to check if the reviews did by @odsantos are observed or resolved. |
|
@jonnathan-ls, do you have time to review and handle this pull request? |
|
@peruibeloko, do you have some time to deal with this pull request? |
gabifs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
Hey @nazarepiedady , this PR still need one more approve |
nazarepiedady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gabifs, you will update this, as soon as possible, but for now, we need to merge and compile every single contribution we gathered. 😊
Thanks for your contribution.
No description provided.