-
-
Notifications
You must be signed in to change notification settings - Fork 112
An Introduction to JavaScript #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An Introduction to JavaScript #240
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I noticed that this article already was merged, and I still am reviewing this.
Thanks.
|
Please make the requested changes. After it, add a comment "/done". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I removed the blank lines that you added, for conforming to the English version.
I also suggested changes to other parts of the text, starting at line 3, besides the ones you're asking for review.
Please, feel free to tell where you disagree.
Thanks,
Osvaldo.
|
Please make the requested changes. After it, add a comment "/done". |
|
@jonnathan-ls, could you review and update this pull request? |
|
/done @odsantos I updated all the notes of corrections and suggestions that you registered @nazarepiedady Update made, if you could leave your review too, please. |
nazarepiedady
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, so we can go ahead.
|
@jonnathan-ls, do you have some time to handle this pull request? @peruibeloko, can you review this pull request? |
gabifs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
An Introduction to JavaScript
π Goal
β What was done?