Skip to content

Conversation

@jonnathan-ls
Copy link
Contributor

@jonnathan-ls jonnathan-ls commented Jun 10, 2022 β€’

An Introduction to JavaScript

πŸ“ Goal

Article update

β˜‘ What was done?

  • Fixed broken links
  • Adjustmented for lack of spacing
  • Added breakdown for naming

@CLAassistant
Copy link

CLAassistant commented Jun 10, 2022 β€’

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@odsantos odsantos left a comment β€’

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I noticed that this article already was merged, and I still am reviewing this.

Thanks.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review πŸ‘»

Copy link
Contributor

@odsantos odsantos left a comment β€’

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

I removed the blank lines that you added, for conforming to the English version.

I also suggested changes to other parts of the text, starting at line 3, besides the ones you're asking for review.

Please, feel free to tell where you disagree.

Thanks,
Osvaldo.

@javascript-translate-bot

Please make the requested changes. After it, add a comment "/done".
Then I'll ask for a new review πŸ‘»

@nazarepiedady
Copy link
Member

@jonnathan-ls, could you review and update this pull request?

@jonnathan-ls
Copy link
Contributor Author

/done

@odsantos I updated all the notes of corrections and suggestions that you registered

@nazarepiedady Update made, if you could leave your review too, please.

Copy link
Member

@nazarepiedady nazarepiedady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, so we can go ahead.

@nazarepiedady
Copy link
Member

@jonnathan-ls, do you have some time to handle this pull request?

@peruibeloko, can you review this pull request?

@nazarepiedady nazarepiedady requested a review from gabifs November 28, 2025 06:36
@nazarepiedady
Copy link
Member

@gabifs

Copy link
Contributor

@gabifs gabifs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabifs gabifs merged commit b464ad1 into javascript-tutorial:master Nov 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants