-
-
Notifications
You must be signed in to change notification settings - Fork 113
Rest parameters and spread operator #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest parameters and spread operator #73
Conversation
|
Hi, hope to do it as soon as possible. Thanks. Cheers. |
odsantos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Luiz,
Once again a great translation.
Would you please have a look at the proposed changes?
Thanks.
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
|
Please make the requested changes. After it, add a comment "/done". |
Of course! Thanks for your review, gonna fix those changes asap :) |
|
Thanks.
On Fri, Oct 11, 2019 at 1:29 PM, Luiz Baldi<notifications@github.com> wrote:
look
Of course! Thanks for you review, gonna fix those changes asap :)
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
/done |
|
Hi, I hope to do it as soon as possible. Thanks. |
odsantos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Luiz,
Would you please consider the following changes?
Thanks.
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
1-js/06-advanced-functions/02-rest-parameters-spread-operator/article.md
Outdated
Show resolved
Hide resolved
|
Please make the requested changes. After it, add a comment "/done". |
|
/done |
odsantos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Luiz,
It seems that your file has many error conflicts.
On such occasions, would you please check the English article for ways to solve them, and see if the translation might match that text as much as possible?
Besides the missing code, the translation could perhaps be taken as finished. Adding 'o' and 'do' where they may not exist, is not a concern.
Thank you.
Regards.
| ```` | ||
| As we remember, arrow functions don't have their own `this`. Now we know they don't have the special `arguments` object either. | ||
| Como nos lembramos, funções _arrow_ não possuem seu próprio `this`. Agora, sabemos que elas também não possuem o especial `arguments`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please,
- '... não possuem o seu próprio
this.'
| alert(merged); // 0,3,5,1,2,8,9,15 (0, then arr, then 2, then arr2) | ||
| alert(merged); // 0,3,5,1,2,8,9,15 (0, depois arr, depois 2, depois arr2) | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please,
The code above seems to contain an error conflict.
(Would you check the English website article (link above)?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't what you mean by "error conflict". The line 192 looks exactly like the original one on the english version, as we can see here. Can you explain to me what exactly should I do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, check Spread operator - 6th code block:
The second array (arr2) is missing
And also formatting characters
| alert( Math.max(1, ...arr1, 2, ...arr2, 25) ); // 25 | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please,
The code above seems to contain an error conflict.
(Would you check the English website article (link above)?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't what you mean by "error conflict". The line 179 looks exactly like the original one on the english version, as we can see here. Can you explain to me what exactly should I do here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, check Spread operator - 5th code block:
The second array (arr2) is missing
| Juntos, eles nos ajudam a efetuar a transição entre uma lista e um _array_ de parâmetros com facilidade. | ||
| All arguments of a function call are also available in "old-style" `arguments`: array-like iterable object. | ||
| Todos os argumentos de uma chamada de função também estão disponíveis na "moda antiga" `arguments`: objeto iterável tipo lista-genérica (_array-like_). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please,
- '... objeto iterável do tipo lista-genérica (array-like).'
| f(1); // 1 | ||
| ``` | ||
| ```` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please,
- The code above seems to contain an error conflict.
So, in such situations would you check the English article (there is a link here) for ways to resolve the conflict?
From the text there, you might know how the Portuguese page would look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get this "error conflicts" at all, sorry. Can you explain me better what you mean by that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure Luiz, would you please simply copy and paste the code from the English site here The “arguments” variable? (Just above "Spread operator")
Please, remove all code inside, so that the strange characters might disappear, such as:
```js run (please leave there) (>>> insert the code here) ``` (please leave there)
(for all cases where conflicts exist, check the English site and copy/paste all needed, including over the strange characters to remove them)
Thanks.
| alert( Math.max(arr) ); // NaN | ||
| */!* | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please,
- The code above seems to contain an error conflict.
(In doubt, would you check the English website article (link here)?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same goes here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, check Spread operator - 2nd code block:
The alert is missing.
Simply copy/paste, as in the example above.
| alert( Math.max(...arr1, ...arr2) ); // 8 | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please,
- The code above seems to contain an error conflict.
(Would you check the English website article (link above)?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The second array (arr2) is missing:
Please, check Spread operator - 4th code block.
|
Please make the requested changes. After it, add a comment "/done". |
|
/done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, would you also check the comments below?
Appreciated for your time.
|
|
||
| alert( sum(1, 2, 3, 4, 5) ); | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
- The function brace needs to be closed.
(you can check it at Rest parameters and spread operator - 1st code block)
Thanks.
| alert( sumAll(1, 2) ); // 3 | ||
| alert( sumAll(1, 2, 3) ); // 6 | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
- There is code missing here.
(you can check it at Rest parameters and spread operator - 2nd code block)
Thanks.
|
|
||
| showName("Julius", "Caesar", "Consul", "Imperator"); | ||
| ``` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
- There is code missing here, too.
(you can check it at Rest parameters and spread operator - 3rd code block)
Thanks.
| f(1); // 1 | ||
| ``` | ||
| ```` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure Luiz, would you please simply copy and paste the code from the English site here The “arguments” variable? (Just above "Spread operator")
Please, remove all code inside, so that the strange characters might disappear, such as:
```js run (please leave there) (>>> insert the code here) ``` (please leave there)
(for all cases where conflicts exist, check the English site and copy/paste all needed, including over the strange characters to remove them)
Thanks.
| alert( Math.max(arr) ); // NaN | ||
| */!* | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, check Spread operator - 2nd code block:
The alert is missing.
Simply copy/paste, as in the example above.
| alert( Math.max(...arr1, ...arr2) ); // 8 | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The second array (arr2) is missing:
Please, check Spread operator - 4th code block.
| alert( Math.max(1, ...arr1, 2, ...arr2, 25) ); // 25 | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, check Spread operator - 5th code block:
The second array (arr2) is missing
| alert(merged); // 0,3,5,1,2,8,9,15 (0, then arr, then 2, then arr2) | ||
| alert(merged); // 0,3,5,1,2,8,9,15 (0, depois arr, depois 2, depois arr2) | ||
| ``` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please, check Spread operator - 6th code block:
The second array (arr2) is missing
And also formatting characters
| So, for a string, `for..of` returns characters and `...str` becomes `"H","e","l","l","o"`. The list of characters is passed to array initializer `[...str]`. | ||
| Então, para uma string, `for..of` retorna caracteres, e `...str` se torna `"O","l","á"`. A lista de caracteres é passada para o inicializador do _array_ `[...str]` | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please,
- "... retorna caracteres, e
...strse torna em"O","l","á"."
(but do not format in bold)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Luiz,
Your translations continue with high quality, as always.
The links you are giving here are very appropriate. There you may click in "Raw" and copy the pieces of code to paste in your file.
Please, do not paste over your translations, but above or below. If such, you may then copy/paste your translations and avoid to translate a second time.
If you have time, I would also appreciate if in the end you could mark as /done, as the bot suggests, because possibly the bot might be able to notify me faster.
Thanks.
|
Please make the requested changes. After it, add a comment "/done". |
Adding translation for "Rest parameters and spread operator".
Feel free to share thoughts on the translation and let me know if any changes are needed :)