Skip to content

OpenAPI: Fix "id" parameter in URL to be string #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2024
Merged

OpenAPI: Fix "id" parameter in URL to be string #1438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
71a72fa
Fixed: Force the "id" parameter type to be string on JSON:API control…
bkoelman Jan 14, 2024
2a42a29
Fixed: no additional properties in resource type
bkoelman Nov 2, 2023
9ba5ec3
Simplify dependencies: take ResourceType instead of ClrType
bkoelman Nov 2, 2023
b0fa688
Fixed: removed unused entries that are not top-level documents
bkoelman Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/usage/openapi-client.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ The next steps describe how to generate a JSON:API client library and use our pa
person => person.FirstName))
{
// Workaround for https://github.com/RicoSuter/NSwag/issues/2499.
await TranslateAsync(async () => await apiClient.PatchPersonAsync(1, null, patchRequest));
await TranslateAsync(async () => await apiClient.PatchPersonAsync(patchRequest.Data.Id, null, patchRequest));

// The sent request looks like this:
// {
Expand Down
4 changes: 2 additions & 2 deletions src/Examples/JsonApiDotNetCoreExample/Properties/launchSettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,15 @@
"IIS Express": {
"commandName": "IISExpress",
"launchBrowser": true,
"launchUrl": "api/todoItems?include=owner,assignee,tags&filter=equals(priority,'High')",
"launchUrl": "swagger",
"environmentVariables": {
"ASPNETCORE_ENVIRONMENT": "Development"
}
},
"Kestrel": {
"commandName": "Project",
"launchBrowser": true,
"launchUrl": "api/todoItems?include=owner,assignee,tags&filter=equals(priority,'High')",
"launchUrl": "swagger",
"applicationUrl": "https://localhost:44340;http://localhost:14140",
"environmentVariables": {
"ASPNETCORE_ENVIRONMENT": "Development"
Expand Down
Loading