boot: zephyr: Remove weird custom key directory handling #2567
+64
−69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code seems to have been introduced by someone without knowledge of the zephyr build system, specifying a Kconfig value in multiple files is a completely legal operation, the one that was applied last is the one that is used, and the default directory for keys should be the application configuration directory, not assuming where a .conf file is specifies the same folder as a key file (which is completely at odds with how Zephyr's file finding CMake code works). Signed-off-by: Jamie McCrae <spam@helper3000.net>
Hides this Kconfig option when the operating mode is set to work as hash only without signature Signed-off-by: Jamie McCrae <spam@helper3000.net>
Moves all mode selections Kconfigs to the choice symbol instead of being all over the place Signed-off-by: Jamie McCrae <spam@helper3000.net>
Adds notes of these changes Signed-off-by: Jamie McCrae <spam@helper3000.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handling is terrible and should never have been introduced, this PR fixes this by adhering to the actual zephyr build system way of locating files and fixes some minor Kconfig annoyances relating to mode selection