Update front-end code for new data structure #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no point in using a list if we're only going to cast it to a set anyway.
This gives us the option of using other display-values for the groups, even though I've decided to stick with the app path for now.
This: - Moves the graphData module over to the new data structure. - Re-arrange the layout of the graph editor.
This makes the clearly different from normal models.
I can't see what this is adding any more.
This is seemingly unused.
The sidebar has been expanded to accommodate the new buttons.
This change means that we can style the graph differently without editing the JS. This will come in handy later if we end up making graphs for other kinds of data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We needed to introduce a new data structure to fix #21. In order to use the new data structure, we needed to re-write a lot of the front-end code.
In the process, the code has been tidied up, and I've added more functionality to the sidebar (including fix #22).
I've had to make some decisions about how the buttons work that might not work for everyone, but I hope will be reasonable defaults.