GH Actions: change PHAR building to reusable workflow #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Note: the branch protection will need a small update for the changed job name. |
09e6ada to
4c61b75
Compare
Collaborator
Author
|
Rebased to solve merge conflicts. No functional changes. |
The workflows currently contain two jobs which build the PHAR files. This means that any changes to the steps in these jobs have to be made in two places. With this in mind, it makes sense to change the PHAR building to a reusable workflow, which can then be used by both jobs. With this change, any changes to the steps of the job will only need to be made in one place. This commit makes it so.
4c61b75 to
c630168
Compare
Collaborator
Author
|
Rebased to solve merge conflicts. No functional changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflows currently contain two jobs which build the PHAR files. This means that any changes to the steps in these jobs have to be made in two places.
With this in mind, it makes sense to change the PHAR building to a reusable workflow, which can then be used by both jobs. With this change, any changes to the steps of the job will only need to be made in one place.
This commit makes it so.