Fix non-conforming code. #216
Merged
+20
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the LOAD-TIME-VALUE entry for CLHS http://clhs.lisp.se/Body/s_ld_tim.htm, "It is guaranteed that the evaluation of form will take place only once when the file is loaded, but the order of evaluation with respect to the evaluation of top level forms in the file is implementation-dependent." Therefore, doing LOAD-TIME-VALUE of a function call where the function is defined in the same file is not portable code. This is important to fix because old versions of CMU CL do take advantage of this fact, and future versions of SBCL may as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the LOAD-TIME-VALUE entry for CLHS
http://clhs.lisp.se/Body/s_ld_tim.htm, "It is guaranteed that the
evaluation of form will take place only once when the file is loaded,
but the order of evaluation with respect to the evaluation of top
level forms in the file is implementation-dependent." Therefore, doing
LOAD-TIME-VALUE of a function call where the function is defined in
the same file is not portable code.
This is important to fix because old versions of CMU CL do take
advantage of this fact, and future versions of SBCL may as well.