Skip to content

Conversation

@vnikolaew
Copy link

Adding a simple JS function for generating random hex color values.

@netlify
Copy link

netlify bot commented Dec 30, 2024

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit 8a69036
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/67725ff6114efb0008c47164
😎 Deploy Preview https://deploy-preview-22--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@Mathys-Gasnier Mathys-Gasnier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert the fact that you put tags in snippets on multiple lines ?
Also, i don't think the Uppercase is necessary, just put the letters as uppercase in the chars.

@technoph1le
Copy link
Collaborator

Could you please revert the fact that you put tags in snippets on multiple lines ?

Perhaps it was due to Prettier?

Also, i don't think the Uppercase is necessary, just put the letters as uppercase in the chars.

I agree with this one, too

@technoph1le technoph1le added the help wanted Extra attention is needed label Dec 30, 2024
@Mathys-Gasnier
Copy link
Collaborator

Yeah probably due to some kind of formating tool, probably one that formats on save

@technoph1le technoph1le added update needed Code needs to be updated. and removed help wanted Extra attention is needed labels Dec 30, 2024
@Mathys-Gasnier
Copy link
Collaborator

Hey, we recently updated how snippets are stored, please update your PR to match the changes, you will be able to see how to add snippets in CONTRIBUTING.md.
For ref: #87

@Mathys-Gasnier
Copy link
Collaborator

Hey, changes were requested on your PR, but we got no news for more than a week, Closing this as stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Snippets update needed Code needs to be updated.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants