Skip to content

Conversation

@cpatra11
Copy link

I have added javascript snippets functions for-

  1. Comprehensive Email validation with temp mail checker
  2. Deep Clone an Object
  3. Detect Device Type
  4. Build a Query String from an Object
  5. Get Multiple URL Query Parameters
  6. Get single URL Parameters

DOM manipulation-
1.Show Loading Spinner
2.Add Class to an Element
3.Remove Class from an Element
4.Set Text Content of an Element

@netlify
Copy link

netlify bot commented Dec 28, 2024

Deploy Preview for quicksnip ready!

Name Link
🔨 Latest commit 99c374b
🔍 Latest deploy log https://app.netlify.com/sites/quicksnip/deploys/6770893ae4d80500082b6baf
😎 Deploy Preview https://deploy-preview-4--quicksnip.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cpatra11 cpatra11 marked this pull request as draft December 28, 2024 23:25
@technoph1le
Copy link
Collaborator

Hi, @cpatra11. Thank your for the contributions. I see that it's still a draft pull request. Once you've finished, I will merge it.

cpatra11

This comment was marked as duplicate.

@cpatra11 cpatra11 closed this Dec 29, 2024
@cpatra11 cpatra11 reopened this Dec 29, 2024
@cpatra11
Copy link
Author

Done reviews, merge it now. More snippets coming...

@technoph1le technoph1le marked this pull request as ready for review December 29, 2024 08:53
@technoph1le
Copy link
Collaborator

@cpatra11 Thank you for the all code snippets. 🙌 And, there's a Show/Hide Loading Spinner(with CSS) in DOM Manipulation category. Since, it contained mostly CSS, it might be better to move it to CSS language instead of JavaScript, and call it Loading Spinner. I would appreciate your review on that.

@technoph1le
Copy link
Collaborator

Also, categorizing them into their correct place would be more helpful for developers to find. I saw that there are 3 code snippets that deal with URL in Function Utilities category. Perhaps, we can make a separate category for them. Same scenario is happening with Objects as well.

@Mathys-Gasnier
Copy link
Collaborator

Most of the URL related stuff are waayy too over complicated, for example query params can just be retrieved using the URL object and it's searchParams value...
And for the validating of email, I don't think fetching some extern source of disposable email provider fits the theme of snippets, I find it way too big, and it relies on something external to this project that can fail at any moment...

@technoph1le technoph1le added help wanted Extra attention is needed question Further information is requested discuss Needs to be discussed by community labels Dec 30, 2024
@Mathys-Gasnier
Copy link
Collaborator

Hey, we recently updated how snippets are stored, please update your PR to match the changes, you will be able to see how to add snippets in CONTRIBUTING.md.
For ref: #87

@Mathys-Gasnier
Copy link
Collaborator

No news of author in over a week, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

discuss Needs to be discussed by community help wanted Extra attention is needed question Further information is requested Snippets

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants