Update javascript.json #71
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added roman to integer code snippet
✅ Deploy Preview for quicksnip ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Mathys-Gasnier
requested changes
Dec 31, 2024
Collaborator
Mathys-Gasnier
left a comment
There was a problem hiding this comment.
Hey, thanks for the contribution !
I've seen you have created two PR and closed them before this one ? Is this for any particular issue/reason ?
Please see the following comment on your code before we can move on with your snippet.
| " if(!toMiss.includes(i)) {", | ||
| " if(next > curr) {", | ||
| " output+=(next-curr);", | ||
| " toMiss.push(i+1);", |
Collaborator
There was a problem hiding this comment.
Instead of having a toMiss array, you could just add 1 to i
Collaborator
|
Hey, we recently updated how snippets are stored, please update your PR to match the changes, you will be able to see how to add snippets in |
Collaborator
|
Hey, changes were requested on your PR, but we got no news for more than a week, Closing this as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added roman to integer code snippet
Description
Type of Change
Checklist
Related Issues
Closes #
Additional Context
Screenshots (Optional)
Click to view screenshots