Skip to content

Conversation

@samael
Copy link
Contributor

@samael samael commented Jan 11, 2018

No description provided.

@DivineOmega
Copy link
Member

Thanks @samael. Could you also modify setup.sh to install PHP 7.1 and dependencies?

@samael
Copy link
Contributor Author

samael commented Jan 12, 2018

Yeap

@samael
Copy link
Contributor Author

samael commented Jan 12, 2018

More fun :)

@DivineOmega
Copy link
Member

This is awesome work! 👍 Thanks.

I'll merge this if you're done?

@samael
Copy link
Contributor Author

samael commented Jan 12, 2018

Feel free.

echo "* Disabling Apache PHP 7.2 module..."
sudo a2dismod php7.2 > /dev/null

echo "* Enabling Apache PHP 7.0 module..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say 'Disabling'.

echo "* Enabling Apache PHP 7.0 module..."
sudo a2dismod php7.0 > /dev/null

echo "* Enabling Apache PHP 7.0 module..."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say PHP 7.1.

echo "* Switching CLI PHP to 7.1..."
sudo update-alternatives --set php /usr/bin/php7.1 > /dev/null

echo "* Switch to PHP 7.0 complete."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should say PHP 7.1.

@DivineOmega
Copy link
Member

Just noticed a few minor typos. Would you mind fixing these up, and then I'll merge?

@samael
Copy link
Contributor Author

samael commented Jan 12, 2018

Everything is fixed. Sorry for my mistakes.

@DivineOmega
Copy link
Member

Awesome. Thanks @samael. 😄

@DivineOmega DivineOmega merged commit d615915 into rapidwebltd:master Jan 12, 2018
DivineOmega pushed a commit that referenced this pull request Mar 30, 2018
Added php-redis extension to setup.sh
DivineOmega pushed a commit that referenced this pull request Mar 23, 2019
Add php7.3 disable commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants