Skip to content
This repository was archived by the owner on Jan 15, 2025. It is now read-only.

Fix misc #6

Merged
merged 3 commits into from
Sep 29, 2020
Merged

Fix misc #6

merged 3 commits into from
Sep 29, 2020

Conversation

@rmorshea
Copy link
Contributor

@rmorshea rmorshea commented Sep 29, 2020

No description provided.

@rmorshea
fix bug where nested element def treated as hook
e1266b8
@rmorshea
fix misc
10214d1 
fixes issue where globals and other variables not defined in
scope of element or hook are considered dependencies of
effects

also fixes problem where, inside the bodies of conditionally
defined hooks or elements, hook usages are considered to be
inside an if statement
@rmorshea
fix types
1fbeaaf
@rmorshea rmorshea merged commit d8ab1f6 into main Sep 29, 2020
@rmorshea rmorshea deleted the fix-misc branch September 29, 2020 07:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rmorshea