Skip to content

Use package:buffer to parse incoming message frames. #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isoos merged 1 commit into from
Mar 14, 2019
Merged

Use package:buffer to parse incoming message frames. #72

isoos merged 1 commit into from
Mar 14, 2019

Conversation

@isoos
Copy link
Collaborator

@isoos isoos commented Dec 7, 2018

  • Simplified the framer code.
  • I think it should be slightly more efficient due to the Queue handling both here and in package:buffer, otherwise the buffer handling looked like conceptually equivalent.

I'd suggest to make it an internal test before merging. I've done a mini-test locally and I'm planning to do a more wider test too.

@isoos isoos requested a review from itsjoeconway December 7, 2018 16:55
@itsjoeconway
Copy link
Contributor

itsjoeconway commented Dec 10, 2018

Ok, I will run it against Aqueduct test suite too. Might be a bit before I get to this

@isoos
Copy link
Collaborator Author

isoos commented Dec 20, 2018

rebased. my larger tests show this working.

@isoos
Copy link
Collaborator Author

isoos commented Dec 22, 2018

An encouragement for package:buffer: apply ByteDataWriter in client_messages.dart makes the average buffer-building time 0.5-0.7 ms faster in bytea-heavy queries. I have seen using list.fold at many places to copy bytes, and it is a low-hanging fruit to make it overall more efficient.

@isoos
Copy link
Collaborator Author

isoos commented Jan 5, 2019

ping?

@isoos isoos changed the base branch from master to dev March 14, 2019 21:47
@isoos
Copy link
Collaborator Author

isoos commented Mar 14, 2019

Switched to dev branch, merging.

@isoos isoos merged commit 8507bb6 into stablekernel:dev Mar 14, 2019
@isoos isoos deleted the buffer branch March 14, 2019 21:48
isoos referenced this pull request in isoos/postgresql-dart May 25, 2019
@isoos
Use package:buffer to parse incoming message frames. (#72)
5a4880e
isoos referenced this pull request in isoos/postgresql-dart Nov 12, 2019
@isoos
Use package:buffer to parse incoming message frames. (#72)
1de4f36
isoos added a commit that referenced this pull request Nov 12, 2019
@isoos
Use package:buffer to parse incoming message frames. (#72)
161bc67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itsjoeconway itsjoeconway Awaiting requested review from itsjoeconway

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@isoos @itsjoeconway