This repository was archived by the owner on Jul 15, 2025. It is now read-only.
Allow SparseNdArray impls to be inherited #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Craigacp
approved these changes
Jan 11, 2022
Contributor
Craigacp
left a comment
There was a problem hiding this comment.
LGTM. The diffs seem bigger than they should be given you just made a method protected, but that doesn't really matter.
| * element in indices. For example, given {@code indices=[[1,3], [2,4]]}, the parameter {@code | ||
| * values=[18, 3.6]} specifies that element {@code [1,3]} of the sparse NdArray has a value of | ||
| * {@code 18}, and element {@code [2,4]} of the NdArray has a value of {@code 3.6}. | ||
| * @param defaultValue Scalar value to set for indices not specified in {@link #getIndices()} |
Contributor
There was a problem hiding this comment.
Maybe this should be {@code indices} rather than {@link #getIndices()}, as it refers to the construction parameter rather than some instance method that you can't actually call when constructing the object.
Contributor
Author
That's because I've moved the now-protected constructor up to the top of the class, to respect the visibility ordering of the class members. Thanks Adam |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just unlocks
SparseNdArrayimplementations constructor to be extended by sub-classes (requires for TensorFlow sparse tensor support)